Ravi Nori has posted comments on this change. Change subject: core : Change ImageSpmCommand to not use placeholder mechanism ......................................................................
Patch Set 4: @Yair If I remove insertAsyncTaskPlaceHolders() from Infra first the commands that use them will have compilation issues. When we introduced this feature in 3.4 we first made changes to infra and then made changes to commands. Now we are practically reverting the 3.4 changes. So first commands then infra. Otherwise I will have to put everything in one patch. -- To view, visit http://gerrit.ovirt.org/37149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I897c9c3cf9e39000f2f2a90b26e01fff7861582c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
