Alon Bar-Lev has posted comments on this change. Change subject: packaging: Use engine.conf for local configuration ......................................................................
Patch Set 1: I think file should be split, service specific parameters should be in /etc/sysconfig. Examples: JBOSS_HOME ENGINE_PID ENGINE_HEAP_MIN=1g ENGINE_HEAP_MAX=1g ENGINE_PERM_MIN=256m ENGINE_PERM_MAX=256m ports... well almost all. BTW: I think ovirt-engine.defaults is missing, or message is incorrect within the ovirt-engine at sysconfig. -- To view, visit http://gerrit.ovirt.org/7591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b48f1fd78ebd891e93949f19fafefcffd377254 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
