Roy Golan has uploaded a new change for review. Change subject: core: missing DbFacade instance in VmDeviceutils ......................................................................
core: missing DbFacade instance in VmDeviceutils the bind into SimpleDependecyInjector of a DbFacade instance was never called. To get DbFacade instances one can use directly the org.ovirt.engine.core.di.Injector instead of using the old SimpleDependcyInjector Change-Id: I5d86293bdff3dc5804f672f8ee0eb0756528e360 Signed-off-by: Roy Golan <rgo...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/37914/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java index de1260c..8eb31d4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java @@ -34,6 +34,7 @@ import org.ovirt.engine.core.compat.Version; import org.ovirt.engine.core.dal.dbbroker.DbFacade; import org.ovirt.engine.core.dao.VmDeviceDAO; +import org.ovirt.engine.core.di.Injector; import org.ovirt.engine.core.vdsbroker.vdsbroker.VdsProperties; import java.util.ArrayList; @@ -56,7 +57,7 @@ private final static int VNC_MIN_MONITORS = 1; private final static int SINGLE_QXL_MONITORS = 1; private static OsRepository osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); - private static DbFacade dbFacade = SimpleDependecyInjector.getInstance().get(DbFacade.class); + private static DbFacade dbFacade = Injector.get(DbFacade.class); private static VmDeviceDAO dao = dbFacade.getVmDeviceDao(); /** -- To view, visit http://gerrit.ovirt.org/37914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5d86293bdff3dc5804f672f8ee0eb0756528e360 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches