Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: add FC Support ......................................................................
Patch Set 6: (1 comment) minor issue, see inline comment http://gerrit.ovirt.org/#/c/37830/6/src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py File src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py: Line 125: ohostedcons.StorageEnv.DOMAIN_TYPE Line 126: ] == ohostedcons.DomainTypes.FC: Line 127: # it's not really possible today to add a FC LUN as a direct LUN Line 128: # but adding it as a fake iSCSI Direct LUN is enough to Line 129: # prevent improper usage os the hosted engine LUN typo error os --> of Line 130: lun = ovirtsdk.xml.params.LogicalUnit( Line 131: id=self.environment[ohostedcons.StorageEnv.GUID], Line 132: address='0.0.0.0', Line 133: port=int(ohostedcons.Defaults.DEFAULT_ISCSI_PORT), -- To view, visit http://gerrit.ovirt.org/37830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I344ee4cdc724a8499c451adbcd8860c3d1e20c27 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
