Alon Bar-Lev has posted comments on this change.

Change subject: core: Fix query size limit handling in AuthzUtils
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/37890/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
File 
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java:

Line 147:         queryImpl(extension, namespace, input, new 
QueryResultHandler() {
Line 148:             @Override
Line 149:             public boolean handle(Collection<ExtMap> queryResults) {
Line 150: 
Line 151:                 boolean result = true;
> if so, we can have some code reuse?
ok, make both hard, did not see above.
Line 152:                 for (ExtMap queryResult : queryResults) {
Line 153:                     if (groups.size() < QUERIES_RESULTS_LIMIT) {
Line 154:                         groups.add(queryResult);
Line 155:                     } else {


-- 
To view, visit http://gerrit.ovirt.org/37890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54cc5a164e007bb75cddca586a6c01f7538b6eb4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to