Sahina Bose has posted comments on this change. Change subject: engine: Quartz cron scheduler to support startAt and endBy ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37533/1/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java: Line 256: Class<?>[] inputTypes, Line 257: Object[] inputParams, Line 258: String cronExpression, Line 259: Date startAt, Line 260: Date endBy) { Validations that startAt < endBy, startAt > now etc? Line 261: JobDetail job = createJobWithBasicMapValues(instance, methodName, inputTypes, inputParams); Line 262: try { Line 263: String triggerName = generateUniqueNameForInstance(instance, TRIGGER_PREFIX); Line 264: Trigger trigger = newTrigger() Line 269: .build(); Line 270: sched.scheduleJob(job, trigger); Line 271: } catch (Exception se) { Line 272: log.error("failed to schedule job: {}", se.getMessage()); Line 273: log.debug("Exception", se); return null in case of exception? Line 274: } Line 275: return job.getKey().getName(); Line 276: } Line 277: -- To view, visit http://gerrit.ovirt.org/37533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3372098177dabbbe886660c9d7a586784b99be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
