Moti Asayag has posted comments on this change. Change subject: engine: Adding getAllVfsConfigByHostId to vfsConfig dao ......................................................................
Patch Set 6: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/36202/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDao.java: Line 7: import org.ovirt.engine.core.dao.GenericDao; Line 8: Line 9: public interface HostNicVfsConfigDao extends GenericDao<HostNicVfsConfig, Guid> { Line 10: /** Line 11: * Retrieves a list of all the vfsConfig on this host. s/on this host./for the given host. Line 12: * Notice: just nics which are SR-IOV enabled have vfsConfig. Line 13: * Line 14: * @param vfsConfigId Line 15: * host nic vfs config id Line 8: Line 9: public interface HostNicVfsConfigDao extends GenericDao<HostNicVfsConfig, Guid> { Line 10: /** Line 11: * Retrieves a list of all the vfsConfig on this host. Line 12: * Notice: just nics which are SR-IOV enabled have vfsConfig. s/just/only Line 13: * Line 14: * @param vfsConfigId Line 15: * host nic vfs config id Line 16: * networkId Line 12: * Notice: just nics which are SR-IOV enabled have vfsConfig. Line 13: * Line 14: * @param vfsConfigId Line 15: * host nic vfs config id Line 16: * networkId please add @param before each parameter Line 17: * network id Line 18: * @return list of all the vfsConfig on this host Line 19: * Line 20: */ Line 14: * @param vfsConfigId Line 15: * host nic vfs config id Line 16: * networkId Line 17: * network id Line 18: * @return list of all the vfsConfig on this host s/on this host./for the given host. Line 19: * Line 20: */ Line 21: List<HostNicVfsConfig> getAllVfsConfigByHostId(Guid hostId); Line 22: http://gerrit.ovirt.org/#/c/36202/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDaoTest.java: Line 334: Line 335: @Test Line 336: public void testGetAllVfsConfigByHostIdWithNoVfsConfigs() { Line 337: List<HostNicVfsConfig> vfsConfigs = dao.getAllVfsConfigByHostId(HOST_WITH_NO_VFS_CONFIGS_ID); Line 338: assertEquals(vfsConfigs.size(), 0); please replace with: assertTrue(vfsConfigs.isEmpty()); Line 339: } -- To view, visit http://gerrit.ovirt.org/36202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cf46155cd86f02c6a77f11f6a46f03fd5171838 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
