Kanagaraj M has posted comments on this change.
Change subject: engine: making gluster peer probe optional while adding Host
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 164: } else {
Line 165: // If cluster supports gluster service do gluster peer
probe
Line 166: // only on non vds installation mode.
Line 167: // Also gluster peer probe is not needed when importing
an existing gluster cluster
Line 168: if (getVdsGroup().supportsGlusterService()
Done
Line 169: && getParameters().isGlusterPeerProbeNeeded() &&
getAllVds(getVdsGroupId()).size() > 1) {
Line 170: String hostName =
Line 171:
(getParameters().getvds().gethost_name().isEmpty()) ?
getParameters().getvds().getManagmentIp()
Line 172: :
getParameters().getvds().gethost_name();
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsActionParameters.java
Line 34: public Guid getVdsForUniqueId() {
Line 35: return vdsId;
Line 36: }
Line 37:
Line 38: public void setIsGlusterPeerProbeNeeded(boolean
isGlusterPeerProbeNeeded) {
Done
Line 39: this.isGlusterPeerProbeNeeded = isGlusterPeerProbeNeeded;
Line 40: }
Line 41:
Line 42: public boolean isGlusterPeerProbeNeeded() {
--
To view, visit http://gerrit.ovirt.org/7391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff6a0e072f686237a4440010acb9701ba0bce87e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
