Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL commands for gluster volume snapshot ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37325/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ActivateGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ActivateGlusterVolumeSnapshotCommand.java: Line 18: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue; Line 19: import org.ovirt.engine.core.common.vdscommands.gluster.GlusterVolumeActivateSnapshotVDSParameters; Line 20: import org.ovirt.engine.core.dao.gluster.GlusterVolumeSnapshotDao; Line 21: Line 22: public class ActivateGlusterVolumeSnapshotCommand extends GlusterVolumeCommandBase<GlusterVolumeSnapshotActionParameters> { > You could extend from a GlusterVolumeSnapshotCommandBase and move common lo will try that Line 23: GlusterVolumeSnapshotEntity snapshot; Line 24: Line 25: public ActivateGlusterVolumeSnapshotCommand(GlusterVolumeSnapshotActionParameters params) { Line 26: super(params); Line 74: } Line 75: Line 76: @Override Line 77: protected Map<String, Pair<String, String>> getExclusiveLocks() { Line 78: if (!isInternalExecution()) { > Check the locking group. Should use the same as the one used in sync job oh yes. this code was done little before the new locking changes. Will change accordingly. Line 79: return Collections.singletonMap(getGlusterVolumeId().toString(), Line 80: LockMessagesMatchUtil.makeLockingPair(LockingGroup.GLUSTER, Line 81: VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED)); Line 82: } -- To view, visit http://gerrit.ovirt.org/37325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74fa567e0910a8f97c3d127951481448983e3fd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
