Daniel Erez has posted comments on this change. Change subject: restapi: Enabling disk information editing when adding a new template. ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/37808/3/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java: Line 146: if (vm.isSetDisks() && vm.getDisks().isSetDisks()) { Line 147: diskToDestinationMap = new HashMap<Guid, DiskImage>(); Line 148: for (Disk disk : vm.getDisks().getDisks()) { Line 149: if (disk.isSetId()) { Line 150: org.ovirt.engine.core.common.businessentities.Disk sourceDisk = queryDisk(disk); is there a test for this logic? Line 151: Line 152: // VM template can only have disk images Line 153: if (sourceDisk.isDiskImage()) { Line 154: DiskImage destinationDisk = (DiskImage) DiskMapper.map(disk, sourceDisk); Line 168: return diskToDestinationMap; Line 169: } Line 170: Line 171: private org.ovirt.engine.core.common.businessentities.Disk queryDisk(Disk disk) { Line 172: VdcQueryReturnValue queryReturnValue = runQuery(VdcQueryType.GetDiskByDiskId, new IdQueryParameters(new Guid(disk.getId()))); the query could fail / returnValue could be null.. use 'getEntity' instead to handle failure. Line 173: return queryReturnValue.getReturnValue(); Line 174: } Line 175: Line 176: @Override -- To view, visit http://gerrit.ovirt.org/37808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
