Eli Mesika has uploaded a new change for review. Change subject: db: reformat code using pgformatter ......................................................................
db: reformat code using pgformatter Currently it is hard to review changed made in DB scripts, the reason is lack of general formatting. For example, in views, there are many columns in the same row and when a column is added it is hard to track the change. That may lead to some problems and regressions after the changed code is merged. The following uses a opensource tool named pgFormatter http://sourceforge.net/projects/pgformatter/ to make our code more readable and friendly for reviews. The formatting is not perfect, bit IMO is much better than the existing one. I am pushing that as a draft to get some feedback. Change-Id: Ie6a426c874b5afad5a4227cd2df47e5491102f71 Signed-off-by: emesika <emes...@redhat.com> --- M packaging/dbscripts/action_version_map_sp.sql M packaging/dbscripts/ad_groups_sp.sql M packaging/dbscripts/affinity_groups_sp.sql M packaging/dbscripts/all_disks_sp.sql M packaging/dbscripts/async_tasks_sp.sql M packaging/dbscripts/attach_user_to_su_role.sql M packaging/dbscripts/audit_log_sp.sql M packaging/dbscripts/base_disks_sp.sql M packaging/dbscripts/bookmarks_sp.sql M packaging/dbscripts/business_entity_snapshot_sp.sql M packaging/dbscripts/cluster_policy_sp.sql M packaging/dbscripts/command_entities_sp.sql M packaging/dbscripts/common_sp.sql M packaging/dbscripts/cpu_profiles_sp.sql M packaging/dbscripts/create_dwh_views.sql M packaging/dbscripts/create_functions.sql M packaging/dbscripts/create_views.sql M packaging/dbscripts/custom_actions_sp.sql M packaging/dbscripts/delete_async_tasks_and_compensation_data.sql M packaging/dbscripts/disk_image_dynamic_sp.sql M packaging/dbscripts/disk_images_sp.sql M packaging/dbscripts/disk_lun_map_sp.sql M packaging/dbscripts/disk_profiles_sp.sql M packaging/dbscripts/drop_db.sql M packaging/dbscripts/dwh_history_timekeeping_sp.sql M packaging/dbscripts/dwh_translation_tables_sp.sql M packaging/dbscripts/engine_sessions_sp.sql M packaging/dbscripts/event_sp.sql M packaging/dbscripts/external_variable_sp.sql M packaging/dbscripts/fence_agents_sp.sql M packaging/dbscripts/gluster_georep_sp.sql M packaging/dbscripts/gluster_hooks_sp.sql M packaging/dbscripts/gluster_server_sp.sql M packaging/dbscripts/gluster_services_sp.sql M packaging/dbscripts/gluster_volume_snapshot_sp.sql M packaging/dbscripts/gluster_volumes_sp.sql M packaging/dbscripts/host_device_sp.sql M packaging/dbscripts/image_storage_domain_map_sp.sql M packaging/dbscripts/images_sp.sql M packaging/dbscripts/inst_sp.sql M packaging/dbscripts/iscsi_bonds_sp.sql M packaging/dbscripts/job_sp.sql M packaging/dbscripts/mac_pools_sp.sql M packaging/dbscripts/materialized_views_sp.sql M packaging/dbscripts/multi_level_administration_sp.sql M packaging/dbscripts/network_sp.sql M packaging/dbscripts/numa_sp.sql M packaging/dbscripts/policy_unit_sp.sql M packaging/dbscripts/providers_sp.sql M packaging/dbscripts/qos_sp.sql M packaging/dbscripts/quota_sp.sql M packaging/dbscripts/repo_files_meta_data_sp.sql M packaging/dbscripts/snapshots_sp.sql M packaging/dbscripts/storages_san_sp.sql M packaging/dbscripts/storages_sp.sql M packaging/dbscripts/system_statistics_sp.sql M packaging/dbscripts/tags_sp.sql M packaging/dbscripts/tags_vm_pool_map_sp.sql M packaging/dbscripts/unregistered_OVF_data_sp.sql M packaging/dbscripts/update_sequence_numbers.sql M packaging/dbscripts/user_sp.sql M packaging/dbscripts/vdc_option_sp.sql M packaging/dbscripts/vds_groups_sp.sql M packaging/dbscripts/vds_kdump_status_sp.sql M packaging/dbscripts/vds_sp.sql M packaging/dbscripts/vds_spm_id_map_sp.sql M packaging/dbscripts/vm_device_sp.sql M packaging/dbscripts/vm_jobs_sp.sql M packaging/dbscripts/vm_pool_maps_sp.sql M packaging/dbscripts/vm_pools_sp.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 72 files changed, 25,179 insertions(+), 18,329 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/48/37848/1 -- To view, visit http://gerrit.ovirt.org/37848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie6a426c874b5afad5a4227cd2df47e5491102f71 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
