Moti Asayag has uploaded a new change for review. Change subject: webadmin: Update bond mode on 3.0 DC (#850423) ......................................................................
webadmin: Update bond mode on 3.0 DC (#850423) https://bugzilla.redhat.com/850423 The patch enables updating bonding options when VLANs are created on top of the bond. It is enabled by exposing the VLAN networks on the list of available networks to the user. Change-Id: If316259f9760777c5f85db0880a157021c61a6bd Signed-off-by: Moti Asayag <masa...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 6 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/7577/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java index 4b5e60f..7e8d61e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java @@ -833,15 +833,12 @@ if (networkDictionary.containsKey(selectedNetworkName)) { Network network = networkDictionary.get(selectedNetworkName); + networksToAdd.add(network); + attachedNetworks.remove(network); - if (!StringHelper.isNullOrEmpty(item.getNetworkName())){ - networksToAdd.add(network); - attachedNetworks.remove(network); - - if (selectedNetwork == null) - { - selectedNetwork = network; - } + if (selectedNetwork == null) + { + selectedNetwork = network; } } } @@ -1947,7 +1944,7 @@ } // If the selected item is a non-attached or attached to vlan eth (over bond or not), // and the selected network in the dialog is a new vlan, attach selected network. - if ((StringHelper.isNullOrEmpty(nic.getNetworkName()) && !isUpdateVlan) + if ((StringHelper.isNullOrEmpty(nic.getNetworkName()) && (nic.getBonded() == null || !nic.getBonded()) && !isUpdateVlan) || (bondWithVlans && (!vLanAttached && network.getvlan_id() != null))) { parameters = new AttachNetworkToVdsParameters(getEntity().getId(), network, nic); -- To view, visit http://gerrit.ovirt.org/7577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If316259f9760777c5f85db0880a157021c61a6bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
