Shubhendu Tripathi has posted comments on this change. Change subject: gluster: DAO for volume snapshot scheduling ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/36486/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java: Line 71: private Integer snapshotsCount; Line 72: Line 73: private Integer snapMaxLimit; Line 74: Line 75: private Boolean snapshotScheduled; > Default this to false. done Line 76: Line 77: private GlusterStatus status; Line 78: Line 79: // Gluster and NFS are enabled by default http://gerrit.ovirt.org/#/c/36486/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java: Line 472: brick.setBrickOrder(0); Line 473: volume.addBrick(brick); Line 474: volume.setSnapshotsCount(0); Line 475: volume.setSnapMaxLimit(0); Line 476: volume.setSnapshotScheduled(false); > Is this required if the default is set? might not be required once default is set. will check that out. Line 477: Line 478: dao.save(volume); Line 479: return volume; Line 480: } -- To view, visit http://gerrit.ovirt.org/36486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie44116df49acc302bfc1b745c00535c1fb0174ad Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
