Eli Mesika has posted comments on this change. Change subject: setup: checking if command_entities table exist ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/37422/8/packaging/setup/dbutils/taskcleaner_sp.sql File packaging/setup/dbutils/taskcleaner_sp.sql: Line 33: CREATE OR REPLACE FUNCTION DeleteAsyncTaskZombiesByCommandId(v_command_id UUID) RETURNS VOID Line 34: AS $procedure$ Line 35: DECLARE Line 36: deleted_rows int; Line 37: root_command_id_of_deleted_cmds UUID; All over this SP: Please change table/column names to lowercase Line 38: BEGIN Line 39: IF (fn_db_is_table_exists ('command_entities')) THEN Line 40: DELETE FROM COMMAND_ENTITIES C WHERE Line 41: C.COMMAND_ID IN ( -- To view, visit http://gerrit.ovirt.org/37422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3152c4d3f6e02915053ada5019abeea7cb356751 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches