Kanagaraj M has posted comments on this change. Change subject: webadmin : Geo-rep Actions UI ......................................................................
Patch Set 14: (3 comments) http://gerrit.ovirt.org/#/c/32538/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 198: allowStopSessionCommand = !allowStartSessionCommand; Line 199: allowResumeSessionCommand = sessionStatus == GeoRepSessionStatus.PAUSED; Line 200: allowPauseSessionCommand = sessionStatus == GeoRepSessionStatus.ACTIVE; Line 201: } else { Line 202: allowStartSessionCommand = false; This is not required. allowStartSessionCommand default value is false. Line 203: } Line 204: getNewSessionCommand().setIsAvailable(true); Line 205: getRemoveSessionCommand().setIsAvailable(false); Line 206: getStartSessionCommand().setIsExecutionAllowed(allowStartSessionCommand); Line 236: } else if (command.getName().equalsIgnoreCase("onPauseGeoRepSession")) {//$NON-NLS-1$ Line 237: onGeoRepSessionAction(VdcActionType.PauseGlusterVolumeGeoRepSession, true); Line 238: } else if (command.getName().equalsIgnoreCase("onResumeGeoRepSession")) {//$NON-NLS-1$ Line 239: onGeoRepSessionAction(VdcActionType.ResumeGeoRepSession, true); Line 240: } else if (command.getName().equalsIgnoreCase("closeWindow")) {//$NON-NLS-1$ duplicate of "cancelWindow" Line 241: closeWindow(); Line 242: } else if(command.equals(getPauseSessionCommand())) { Line 243: pauseGeoRepSession(); Line 244: } else if(command.equals(getResumeSessionCommand())) { Line 242: } else if(command.equals(getPauseSessionCommand())) { Line 243: pauseGeoRepSession(); Line 244: } else if(command.equals(getResumeSessionCommand())) { Line 245: resumeGeoRepSession(); Line 246: } Can these moved above near to start/stop ? Line 247: Line 248: } Line 249: Line 250: private void closeWindow() { -- To view, visit http://gerrit.ovirt.org/32538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46fbd79f714175e3ad3ce76d858714c6fec3fdde Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
