Eli Mesika has posted comments on this change. Change subject: history: update dwh_vm_disks_history_view ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37798/1/packaging/dbscripts/create_dwh_views.sql File packaging/dbscripts/create_dwh_views.sql: Line 405: FROM images Line 406: INNER JOIN Line 407: disk_image_dynamic ON images.image_guid = disk_image_dynamic.image_id Line 408: INNER JOIN Line 409: base_disks as d ON images.image_group_id = d.disk_id woooooooooooooo What a change ... Did you test how this affects performance on large installations ??? Line 410: LEFT OUTER JOIN Line 411: vm_device ON vm_device.device_id = images.image_group_id Line 412: LEFT OUTER JOIN Line 413: vm_static ON vm_static.vm_guid = vm_device.vm_id -- To view, visit http://gerrit.ovirt.org/37798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a96176c6b2c8455cb46f53cbcc71b6d64ef1efe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
