Moti Asayag has uploaded a new change for review.
Change subject: engine: Avoid potential NPE reported by Coverity
......................................................................
engine: Avoid potential NPE reported by Coverity
>>> CID 1269335: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "contentHosts".
Change-Id: Ia100de3d4ec5ed0eefe7c45372c9f3fe1300b05d
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/37765/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
index 5c8802b..c5e263c 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
@@ -338,7 +338,7 @@
objectMapper.readValue(runHttpGetMethod(relativeUrl),
ContentHostsWrapper.class);
return Arrays.asList(wrapper.getResults());
} catch (IOException e) {
- return null;
+ return Collections.emptyList();
}
}
--
To view, visit http://gerrit.ovirt.org/37765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia100de3d4ec5ed0eefe7c45372c9f3fe1300b05d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
