Yevgeny Zaspitsky has uploaded a new change for review.

Change subject: engine: remove produceLogger method
......................................................................

engine: remove produceLogger method

Logger is instanciated statically by every class.
Having that as a CDI bean is redundant.

Change-Id: I807579725141908e3434ebb841925bc5b8a22711
Signed-off-by: Yevgeny Zaspitsky <yzasp...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
1 file changed, 0 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/37759/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
index 244b941..5f5124e 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
@@ -1,7 +1,6 @@
 package org.ovirt.engine.core.bll.utils;
 
 import javax.enterprise.inject.Produces;
-import javax.enterprise.inject.spi.InjectionPoint;
 
 import org.ovirt.engine.core.dal.dbbroker.DbFacade;
 import org.ovirt.engine.core.dao.StoragePoolDAO;
@@ -11,8 +10,6 @@
 import org.ovirt.engine.core.dao.network.InterfaceDao;
 import org.ovirt.engine.core.dao.network.NetworkClusterDao;
 import org.ovirt.engine.core.dao.network.NetworkDao;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * This class is made to keep all producers of bll dependencies, generally 
singletons from other jars in one place for the
@@ -31,23 +28,6 @@
 
     @Produces
     DbFacade dbFacade = DbFacade.getInstance();
-
-    /**
-     * this producer enables injection of Logger instance. Its not
-     * intended to be used as protected instance as the runtime instance is 
the declaring class so
-     * use directly as a private member.
-     *
-     *  <code>
-     *      @Inject
-     *      private Logger log;
-     *  </code>
-     *
-     * @param injectionPoint
-     */
-    @Produces
-    public Logger produceLogger(InjectionPoint injectionPoint) {
-        return 
LoggerFactory.getLogger(injectionPoint.getMember().getDeclaringClass());
-    }
 
     @Produces
     private NetworkDao produceNetworkDao(DbFacade dbFacade) {
@@ -87,5 +67,4 @@
     private BllCDIAdapter() {
         // hide me
     }
-
 }


-- 
To view, visit http://gerrit.ovirt.org/37759
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I807579725141908e3434ebb841925bc5b8a22711
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to