Juan Hernandez has posted comments on this change. Change subject: core,restapi: added reported differences element to api.xsd + returning reported differences from GetNetworkAttachment queries ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37407/3/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 3909: <xs:element name="name" type="xs:string"/> Line 3910: <xs:element name="value" type="xs:string"/> Line 3911: <xs:element name="in_sync" type="xs:boolean"/> Line 3912: </xs:sequence> Line 3913: </xs:complexType> This looks pretty much like a set of properties, except for the "in_sync" flag. Would it be possible to use the existing "properties" element? Line 3914: Line 3915: <xs:element name="ip_configuration" type="IpConfiguration"/> Line 3916: Line 3917: <xs:complexType name="IpConfiguration"> -- To view, visit http://gerrit.ovirt.org/37407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7f83d268e250c24c4eeee6bff832426699ad95d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
