Roy Golan has posted comments on this change. Change subject: core: Lazy init ArrayList when monitoring lun ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37497/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 230: externalVms.add(new Pair<>(vmUpdater.getDbVm(), vmUpdater.getVdsmVm())); Line 231: } Line 232: Line 233: if (!vmUpdater.getUpdatedLuns().isEmpty()) { Line 234: vmUpdater.getUpdatedLuns().addAll(vmLunDisksToSave); > its a little weird changing the list inside vmUpdater and using it.. thats exactly the purpose of the analyzer. to gather data. and the vmsmonitoring to use it and not the other way around. we should gradually move the rest into the analyzer I think. trying to keep separating the responsibilities between classes. Line 235: vmLunDisksToSave = vmUpdater.getUpdatedLuns(); Line 236: } Line 237: } Line 238: -- To view, visit http://gerrit.ovirt.org/37497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id43aa4995f9170cafea45e5998c2c305e9d1462c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
