Nir Soffer has posted comments on this change.

Change subject: packaging: setup: showing the GUID instead of the physical dev 
on iSCSI setup
......................................................................


Patch Set 11: Code-Review+1

Looks good.

For another patch:

[ ERROR ] Error: device 330000000ec116e3f has capacity of only 1024Mb while a 
minimum of 20480Mb is  required

The error talks about Mb but it should talk about GiB.

-- 
To view, visit http://gerrit.ovirt.org/37494
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8cd9c02e8c753db5df6816a38317b493c9b1e7f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to