Allon Mureinik has posted comments on this change. Change subject: core:[WIP] Add validation when Storage Domain is blocked. ......................................................................
Patch Set 1: Code-Review-1 (2 comments) Giving -1 just in case, so it won't be merged until the clarifying question is answered. http://gerrit.ovirt.org/#/c/37729/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java: Line 46: addStorageDomainInDb(); Line 47: try { Line 48: updateStorageDomainDynamicFromIrs(); Line 49: } catch (VdcBLLException e) { Line 50: log.error("Could not succeeded to get storage domain stat. Message: {}", e.getMessage()); That's a convoluted sentence - just use "Could not get the Storage Domain's stats." Line 51: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_PROBLEM_WITH_CANDIDATE_INFO); Line 52: return; Line 53: } Line 54: Line 48: updateStorageDomainDynamicFromIrs(); Line 49: } catch (VdcBLLException e) { Line 50: log.error("Could not succeeded to get storage domain stat. Message: {}", e.getMessage()); Line 51: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_PROBLEM_WITH_CANDIDATE_INFO); Line 52: return; should we add CDA messages in the execute phase? Line 53: } Line 54: Line 55: // Add relevant LUNs to DB Line 56: List<LUNs> luns = getLUNsFromVgInfo(getStorageDomain().getStorage()); -- To view, visit http://gerrit.ovirt.org/37729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a7c12609b3780c74396dab6edf26e4deaff490f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
