Kanagaraj M has posted comments on this change. Change subject: webadmin : Geo-rep Actions UI ......................................................................
Patch Set 10: (4 comments) Braces missing in lot of places. Is this intentional? http://gerrit.ovirt.org/#/c/32538/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 153: Line 154: @Override Line 155: public void search() Line 156: { Line 157: if (getEntity() != null) why the braces removed? Line 158: super.search(); Line 159: } Line 160: Line 161: @Override Line 159: } Line 160: Line 161: @Override Line 162: protected void syncSearch() { Line 163: if (getEntity() == null) same here Line 164: return; Line 165: Line 166: AsyncDataProvider.getInstance().getGlusterVolumeGeoRepStatusForMasterVolume(new AsyncQuery(this, new INewAsyncCallback() { Line 167: @Override Line 196: allowStartSessionCommand = false; Line 197: getNewSessionCommand().setIsAvailable(true); Line 198: getRemoveSessionCommand().setIsAvailable(false); Line 199: getStartSessionCommand().setIsExecutionAllowed(allowStartSessionCommand); Line 200: getStopSessionCommand().setIsExecutionAllowed(!allowStartSessionCommand); allowStopSessionCommand? Line 201: getPauseSessionCommand().setIsExecutionAllowed(allowPauseSessionCommand); Line 202: getResumeSessionCommand().setIsExecutionAllowed(allowResumeSessionCommand); Line 203: getSessionOptionsCommand().setIsExecutionAllowed(true); Line 204: getViewSessionDetailsCommand().setIsAvailable(false); Line 290: Line 291: cModel.setForceHelp(forceHelp); Line 292: cModel.setForceLabel(forceLabelText); Line 293: Line 294: cModel.startProgress(constants.fetchingDataMessage()); shouldn't this be performing *some* action instead of fetching data? Line 295: Line 296: cModel.getCommands().add(okCommand); Line 297: Line 298: UICommand cancelCommand = new UICommand("closeWindow", this);//$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/32538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46fbd79f714175e3ad3ce76d858714c6fec3fdde Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
