Roy Golan has submitted this change and it was merged.
Change subject: core: Introduce postConstruct for commands
......................................................................
core: Introduce postConstruct for commands
Replace the need to call DbFacade or other interaction with the command
dependencies during the constructor.
It is ensured (by CommandFactory) that all the command injected
dependencies are already in place.
so instead of:
public DoThisCommand(P p) {
DbFacade.getInstance().getVmDao...
}
we would:
@Override
protected postConstruct() {
dbFacade.getVmDao...
}
Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Roy Golan: Verified
--
To view, visit http://gerrit.ovirt.org/37599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
