Alon Bar-Lev has posted comments on this change. Change subject: aaa: add support for basic athentication ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/37299/11/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/ExternalAuthServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/ExternalAuthServlet.java: Line 43: try { Line 44: caps |= Authn.Capabilities.class.getField(AUTHENTICATE_NEGOTIATE_INTERACTIVE).getLong(null); Line 45: } catch (IllegalArgumentException | IllegalAccessException | NoSuchFieldException ex) { Line 46: log.error("Error calculating authn capabilities while accessing constant {}", AUTHENTICATE_NEGOTIATE_INTERACTIVE); Line 47: } > DO we need another init param to enable negotiate interactive? two options... 1. this url is only for interactive - then we can use both extensions types. 2. this url serves both interactive and non interactive, and the mode is determined by the url of phase0, for example: if you access /login -> interactive, if you access /get-ticket -> non interactive. then we need to pass the mode into the chain of phases, when we reach here we know what mode we are either by query parameter or session variable. Line 48: Line 49: final AuthenticationProfileRepository repo = (AuthenticationProfileRepository) getServletContext().getAttribute(SSOUtils.AUTH_PROFILE_REPOSITORY); Line 50: repo.addObserver( Line 51: new Observer() { -- To view, visit http://gerrit.ovirt.org/37299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If09285f0e6cd8909f21aa7e88ae1a3c1a30763c2 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
