Maor Lipchuk has posted comments on this change. Change subject: core: Code duplication refactoring. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37654/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-02-10 12:16:39 +0200 Line 6: Line 7: core: Code duplication refactoring. Line 8: Line 9: The check if a disk's interface was updated in VM disk's updating is being > Please remove redundant "The" Suggestion: I would rephrase it a bit differently. use the term validation instead of "The check" Maybe something like: "Use an existing parameter for validating disk interface when update a VM disk" I would also change the summary to be the same (not sure it is refactoring) maybe "clean duplicate code" Line 10: called twice at the same scope, thus it is now valuated only once. Line 11: Line 12: Change-Id: Ic4ffa5b7a1647f0faade0d515740f02665ff1607 -- To view, visit http://gerrit.ovirt.org/37654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4ffa5b7a1647f0faade0d515740f02665ff1607 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
