Yair Zaslavsky has uploaded a new change for review.

Change subject: webadmin: Fix permission addition
......................................................................

webadmin: Fix permission addition

Permission model used an empty CTOR which is
required for serialization, without setting a proper ID.

Change-Id: Iaed42ab3e49172854c58024841bf2c097ca626c3
Bug-Url: https://bugzilla.redhat.com/1186722
Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/37612/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
index 1703d0f..5d37a8d 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
@@ -238,13 +238,7 @@
         ArrayList<VdcActionParametersBase> list = new 
ArrayList<VdcActionParametersBase>();
         for (DbUser user : items)
         {
-            Permissions tempVar2 = new Permissions();
-            tempVar2.setad_element_id(user.getId());
-            tempVar2.setrole_id(role.getId());
-            Permissions perm = tempVar2;
-            perm.setObjectId(getEntityGuid());
-            perm.setObjectType(this.getObjectType());
-
+            Permissions perm = new Permissions(user.getId(), role.getId(), 
getEntityGuid(), getObjectType());
             if (user.isGroup())
             {
                 DbGroup group = new DbGroup();


-- 
To view, visit http://gerrit.ovirt.org/37612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaed42ab3e49172854c58024841bf2c097ca626c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to