Lior Vernia has posted comments on this change.

Change subject: webadmin: Display total RX/TX in interface subtabs
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.ovirt.org/#/c/36471/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java:

Line 798:     @DefaultStringValue("Speed")
Line 799:     String speedInterface();
Line 800: 
Line 801:     @DefaultStringValue("Rx Rate")
Line 802:     String rxInterface();
> please rename to rxRate
Done
Line 803: 
Line 804:     @DefaultStringValue("Tx Rate")
Line 805:     String txInterface();
Line 806: 


Line 801:     @DefaultStringValue("Rx Rate")
Line 802:     String rxInterface();
Line 803: 
Line 804:     @DefaultStringValue("Tx Rate")
Line 805:     String txInterface();
> please rename to txRate
Done
Line 806: 
Line 807:     @DefaultStringValue("Total Rx")
Line 808:     String rxTotal();
Line 809: 


-- 
To view, visit http://gerrit.ovirt.org/36471
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21f4f05d79de76f7b058a091e27b3aca6badf94e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to