Lior Vernia has posted comments on this change. Change subject: webadmin: Clean up interface cloning code ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36464/4//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-01-14 14:22:19 +0200 Line 6: Line 7: webadmin: Clean up interface cloning code Line 8: Line 9: VdsNetworkInterface entities didn't seem to be cloned at all so that > Since you're already refactoring the Cloner class, consider removing the lo Done Line 10: code was removed, while the code cloning VmNetworkInterface was Line 11: modified to use a type-safe overload of the clone() method (instead of Line 12: the generic one that uses reflection). Line 13: -- To view, visit http://gerrit.ovirt.org/36464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cfb4517ea2deb7fc6d5b49587c16b1d34026552 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
