[Engine-patches] Change in ovirt-engine[master]: core: use postConstruct in AddVmCommand

[rgolan]

Roy Golan has uploaded a new change for review.

Change subject: core: use postConstruct in AddVmCommand
......................................................................

core: use postConstruct in AddVmCommand

Change-Id: Ia2ba2b140d4b40fa84beeb0d9c2894f8cc2098ae
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
2 files changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/37601/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
index 6683e93..0a6c62a 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
@@ -132,6 +132,10 @@
         setVmName(parameters.getVm().getName());
         parameters.setVmId(getVmId());
         setStorageDomainId(getParameters().getStorageDomainId());
+    }
+
+    protected void postConstruct() {
+        T parameters = getParameters();
         if (parameters.getVmStaticData() != null) {
             Guid templateIdToUse = 
getParameters().getVmStaticData().getVmtGuid();
 
diff --git 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
index bfb24cd..4ea490e 100644
--- 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
+++ 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
@@ -209,6 +209,7 @@
         final int domainSizeGB = 20;
         final int sizeRequired = 5;
         AddVmCommand<AddVmParameters> cmd = setupCanAddVmTests(domainSizeGB, 
sizeRequired);
+        cmd.postConstruct();
         doReturn(true).when(cmd).validateCustomProperties(any(VmStatic.class), 
any(ArrayList.class));
         doReturn(true).when(cmd).validateSpaceRequirements();
         assertTrue("vm could not be added", cmd.canAddVm(reasons, 
Arrays.asList(createStorageDomain(domainSizeGB))));
@@ -253,7 +254,6 @@
     public void canAddVmWithVirtioScsiControllerNotSupportedOs() {
         VM vm = createVm();
         AddVmFromTemplateCommand<AddVmParameters> cmd = 
createVmFromTemplateCommand(vm);
-
         VDSGroup vdsGroup = createVdsGroup();
 
         mockStorageDomainDAOGetForStoragePool();
@@ -404,6 +404,7 @@
         mockDAOs(result);
         mockBackend(result);
         initCommandMethods(result);
+        result.postConstruct();
         return result;
     }
 


-- 
To view, visit http://gerrit.ovirt.org/37601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2ba2b140d4b40fa84beeb0d9c2894f8cc2098ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches