Lior Vernia has posted comments on this change. Change subject: webadmin: Update HostSetupNetworks flow to use isManagement ......................................................................
Patch Set 19: Code-Review+2 (2 comments) Please note small comments. http://gerrit.ovirt.org/#/c/37028/19/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java: Line 17: */ Line 18: public class LogicalNetworkModel extends NetworkItemModel<NetworkStatus> { Line 19: Line 20: private boolean selected; Line 21: private boolean management; Don't you want this to be final? Line 22: private boolean attachedViaLabel; Line 23: private String errorMessage; Line 24: private NetworkInterfaceModel attachedToNic; Line 25: private NetworkInterfaceModel vlanNicModel; Line 26: Line 27: public LogicalNetworkModel(Network network, HostSetupNetworksModel setupModel) { Line 28: super(setupModel); Line 29: setEntity(network); Line 30: if (network.getCluster() != null && network.getCluster().isManagement()) { I would just write management = (network.getCluster() != null && network.getCluster().isManagement()), but that's a matter of style. Line 31: management = true; Line 32: } Line 33: } Line 34: -- To view, visit http://gerrit.ovirt.org/37028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bb6d8149d895a5834c5fb59e357a9acab7cb00d Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
