Alona Kaplan has posted comments on this change. Change subject: engine: Persist total RX/TX in compatible hosts/VMs ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/36470/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java: Line 67: public static final String rx_total = "rx"; // in vm also Line 68: public static final String tx_dropped = "txDropped"; // in vm also Line 69: public static final String tx_rate = "txRate"; // in vm also Line 70: public static final String tx_total = "tx"; // in vm also Line 71: public static final String iface_status = "state"; // in vm also Didn't find any use case of this field for vms. Line 72: public static final String sample_time = "sampleTime"; // in vm also Line 73: public static final String vm_active = "vmActive"; Line 74: public static final String vm_count = "vmCount"; Line 75: public static final String vm_migrating = "vmMigrating"; http://gerrit.ovirt.org/#/c/36470/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java: Line 531: obj.setReceivedBytesOffset(instance.getReceivedBytesOffset()); Line 532: obj.setTransmitDropRate(instance.getTransmitDropRate()); Line 533: obj.setTransmitRate(instance.getTransmitRate()); Line 534: obj.setTransmittedBytes(instance.getTransmittedBytes()); Line 535: obj.setTransmittedBytesOffset(instance.getTransmittedBytesOffset()); what about the sample time? Line 536: obj.setStatus(instance.getStatus()); Line 537: } Line 538: Line 539: private static VmNetworkStatistics cloneVmNetworkStatistics(VmNetworkStatistics instance) -- To view, visit http://gerrit.ovirt.org/36470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3063bb36fb7e4d5a545d42c648091688ce1e6964 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
