Liron Aravot has posted comments on this change. Change subject: core: Limitation addition for downgrading DC's compatible version. ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37478/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java: Line 546: if (domainStatic.getStorageDomainType().isIsoOrImportExportDomain()) { Line 547: return true; Line 548: } Line 549: Line 550: if (storagePool != null) { I'm not sure about this part - why do we use preferred? for example, if you'll attempt to attach v2 file domain (if there's such a thing) to a v3 dc you'll get preferred v1 and will fail here. Line 551: if (VersionStorageFormatUtil.getPreferredForVersion(storagePool.getcompatibility_version(), Line 552: domainStatic.getStorageType()).compareTo(domainStatic.getStorageFormat()) < 0) { Line 553: return false; Line 554: } -- To view, visit http://gerrit.ovirt.org/37478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib97488c705a32fe73b390ef226b1ad19a3784b76 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
