Yevgeny Zaspitsky has posted comments on this change. Change subject: webadmin: management notion is removed from Network-general sub-tab ......................................................................
Patch Set 17: (3 comments) http://gerrit.ovirt.org/#/c/37030/17/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java: Line 55 Line 56 Line 57 Line 58 Line 59 > Can't this constant be removed? Done Line 63 Line 64 Line 65 Line 66 Line 67 > Likewise. Done Line 77: Line 78: public void setVmNetwork(Boolean vmNetwork) { Line 79: if (!ObjectUtils.objectsEqual(this.vmNetwork, vmNetwork)) { Line 80: this.vmNetwork = vmNetwork; Line 81: onPropertyChanged(new PropertyChangedEventArgs("Vm Network")); //$NON-NLS-1$ > You don't need this, nobody was listening on the "Role" property changed ev Done Line 82: } Line 83: } Line 84: Line 85: public Integer getVlan() { -- To view, visit http://gerrit.ovirt.org/37030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b1aaf1eaea137953d8542d02d16fc4c710b4eee Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
