Moti Asayag has posted comments on this change. Change subject: core: Maintain Java style for UpdateVdsActionParameters ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37466/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java: Line 261: getStrippedVdsUniqueId(), Line 262: getParameters().getVdsPort(), Line 263: IsPending); Line 264: UpdateVdsActionParameters p = new UpdateVdsActionParameters(vds.getStaticData(), "", false); Line 265: p.setInstallHost(!IsPending); > then change the subject of the patch. this is not java style issue :) is this a code that was added or changed within this patch ? no... by that logic i should send a single huge patch to fix whatever naming convention violation in the repository The commit message restrict this change to: "core: Maintain Java style for UpdateVdsActionParameters" Line 266: p.setReinstallOrUpgrade(!IsPending); Line 267: p.setAuthMethod(VdsOperationActionParameters.AuthenticationMethod.PublicKey); Line 268: if (vds.isFenceAgentsExist()) { Line 269: p.setFenceAgents(vds.getFenceAgents()); -- To view, visit http://gerrit.ovirt.org/37466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdf57cbffac354873bb37ef92944ba1de6b0c71c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
