Daniel Erez has posted comments on this change. Change subject: webadmin: Added place holder for watchdog model. ......................................................................
Patch Set 9: (5 comments) http://gerrit.ovirt.org/#/c/36688/9//COMMIT_MSG Commit Message: Line 8: Line 9: When adding new VM the watchdog model didn't have a place holder like Line 10: the watchdog action did. So a place holder was added "<No Watchdog>" Line 11: to comply with current UI design standards. Line 12: watchdog model ListModelListBoxEditor class was changed to has it been changed in another patch? Line 13: ListModelTypeAheadChangeableListBoxEditor Line 14: inorder to add support for the new place holder. Line 15: Line 16: Change-Id: Ice4111935a0ec3bb29237660702e536adbc34d14 http://gerrit.ovirt.org/#/c/36688/9/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java: Line 2003: @DefaultStringValue("Graphics protocol") Line 2004: String graphicsProtocol(); Line 2005: Line 2006: @DefaultStringValue("<No-Watchdog>") Line 2007: String noWatchdogLabal(); s/Labal/Label http://gerrit.ovirt.org/#/c/36688/9/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 26: import com.google.gwt.user.client.ui.Panel; Line 27: import com.google.gwt.user.client.ui.RadioButton; Line 28: import com.google.gwt.user.client.ui.ValueLabel; Line 29: import com.google.gwt.user.client.ui.Widget; Line 30: not relevant to the patch.. Line 31: import java.util.ArrayList; Line 32: import java.util.Arrays; Line 33: import java.util.HashMap; Line 34: import java.util.List; Line 32: import java.util.Arrays; Line 33: import java.util.HashMap; Line 34: import java.util.List; Line 35: import java.util.Map; Line 36: same Line 37: import org.ovirt.engine.core.common.businessentities.BootSequence; Line 38: import org.ovirt.engine.core.common.businessentities.Disk; Line 39: import org.ovirt.engine.core.common.businessentities.Disk.DiskStorageType; Line 40: import org.ovirt.engine.core.common.businessentities.DiskImage; Line 876: Line 877: private final Map<TabName, DialogTab> tabMap = new HashMap<TabName, DialogTab>(); Line 878: Line 879: @SuppressWarnings({ "unchecked", "rawtypes" }) Line 880: public AbstractVmPopupWidget(final CommonApplicationConstants constants, same Line 881: CommonApplicationResources resources, Line 882: final CommonApplicationMessages messages, Line 883: CommonApplicationTemplates applicationTemplates, Line 884: EventBus eventBus) { -- To view, visit http://gerrit.ovirt.org/36688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice4111935a0ec3bb29237660702e536adbc34d14 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
