Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: allow to disable iptables overriding ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37535/1/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 642: ], Line 643: ), Line 644: override_iptables=self.environment[ Line 645: constants.NetEnv.IPTABLES_ENABLE Line 646: ], > What happens if user chose firewalld? Firewalld is disabled in hosted engine, so user can't choose it. Line 647: ) Line 648: ) Line 649: except ovirtsdk.infrastructure.errors.RequestError as e: Line 650: self.logger.debug( -- To view, visit http://gerrit.ovirt.org/37535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8244440989f486b1006fbe05151cb1fc9aa1fa1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
