Alexander Wels has posted comments on this change. Change subject: webadmin: Host General sub tab ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37387/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java: Line 91: } Line 92: Line 93: @SuppressWarnings("unchecked") Line 94: @Override Line 95: public void prepareFromRequest(PlaceRequest request) { > this looks like the part that fixes that rendering bug. And it looks like i That is correct, as far as I know there are no other places that use this type of sub sub tab setup, so no there are AFAIK no other places. Line 96: super.prepareFromRequest(request); Line 97: Line 98: if (getProxy() instanceof TabContentProxyPlace && getMainTabRequest() != null) { Line 99: // Reveal presenter only when there is something selected in the main tab -- To view, visit http://gerrit.ovirt.org/37387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie70cee7d4c5742a51ba6084968cf8617d0e2680e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
