Yevgeny Zaspitsky has posted comments on this change. Change subject: webadmin: Add managemenet network field to new/edit cluster dialog ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/37141/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java: Line 1340: return lexoNumeric.compare(cluster1.getName(), cluster2.getName()); Line 1341: } Line 1342: } Line 1343: Line 1344: public final static class NetworkComparator implements Comparator<Network>, Serializable { > In a previous patch I suggested to modify this to only be used in a specifi Moved to the mentioned patch and fixed there Line 1345: Line 1346: private static final long serialVersionUID = 990203400356561587L; Line 1347: private final LexoNumericComparator lexoNumeric = new LexoNumericComparator(); Line 1348: http://gerrit.ovirt.org/#/c/37141/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 656 Line 657 Line 658 Line 659 Line 660 > Why did you add this method in a previous patch only to remove it? It can s Done Line 649: aQuery); Line 650: } Line 651: Line 652: public void getDefaultManagementNetwork(AsyncQuery aQuery, Guid dataCenterId) { Line 653: aQuery.converterCallback = new AsIsAsyncConverter(); > Why not convert to Network here? I'm not sure I understand you Line 654: Frontend.getInstance().runQuery( Line 655: VdcQueryType.GetDefaultManagementNetwork, Line 656: new IdQueryParameters(dataCenterId), Line 657: aQuery); -- To view, visit http://gerrit.ovirt.org/37141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I055babd6037f127235c349499f1545396e38333f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
