Alona Kaplan has posted comments on this change. Change subject: engine, webadmin: refactor manage networks flow ......................................................................
Patch Set 44: Code-Review+2 (2 comments) Please notice there are two small comments. http://gerrit.ovirt.org/#/c/33684/44/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java: Line 68: combinedInterfaces.add(nic); Line 69: final VdsNetworkInterface nicRemainedAfterRemove = interfacesRemainedAfterRemoveByName.get(nicName); Line 70: final VdsNetworkInterface originalNic = originalInterfacesByName.get(nicName); Line 71: final String networkName = combineNonVlanNetwork(nicName, Line 72: nicRemainedAfterRemove == null ? null : nicRemainedAfterRemove.getNetworkName(), This is non-vlan nic, it can't be null (can't be removed). Line 73: originalNic == null ? null : originalNic.getNetworkName()); Line 74: nic.setNetworkName(networkName); Line 75: } Line 76: } Line 76: } Line 77: return resultParam; Line 78: } Line 79: Line 80: private String combineNonVlanNetwork( 1. The name of the method is unclear, maybe- getNonVlanCombinedNetworkName() 2. The method can be shortened to- if (Objects.equals(networkNameAfterAdd, originalNetworkName)) { return networkNameAfterRemove; } return networkNameAfterAdd; Line 81: String networkNameAfterAdd, Line 82: String networkNameAfterRemove, Line 83: String originalNetworkName) { Line 84: if (networkNameAfterAdd == null) { // nic with no network, no change -- To view, visit http://gerrit.ovirt.org/33684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0b86d8bb018a6172891cb357a4402cfef135d1 Gerrit-PatchSet: 44 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
