Daniel Erez has posted comments on this change. Change subject: webadmin: Enabling paused VM's disk editing. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37485/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java: Line 638: getChangeQuotaCommand()); Line 639: } Line 640: Line 641: private boolean isEnvironmentValidForDiskEdit(Disk disk) { Line 642: return isVmDown() || !disk.getPlugged() || (isExtendImageSizeSupported() && isExtendImageSizeEnabled()) || (getEntity() != null && getEntity().getStatus().equals(VMStatus.Paused)); why not simply check isVmDownOrPaused? what's the validation in canDo? Line 643: } Line 644: Line 645: public boolean isVmDown() { Line 646: VM vm = getEntity(); -- To view, visit http://gerrit.ovirt.org/37485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d3ac2000c86078ce4fd4ff6d47e804b8848167 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
