Sandro Bonazzola has posted comments on this change.

Change subject: WIP: add glusterfs support to hosted engine setup
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/36108/8/src/plugins/ovirt-hosted-engine-setup/storage/glusterfs.py
File src/plugins/ovirt-hosted-engine-setup/storage/glusterfs.py:

Line 54:     def _configure_glusterfs_service(self):
Line 55:         """
Line 56:         @see: http://www.ovirt.org/Features/GlusterFS_Storage_Domain
Line 57:         #Important_Pre-requisites
Line 58:         """
Maybe we should drop this, following 
https://bugzilla.redhat.com/show_bug.cgi?id=1181466#c1
Line 59:         content = []
Line 60:         with open(ohostedcons.FileLocations.GLUSTERD_VOL, 'r') as f:
Line 61:             for line in f.read().splitlines():
Line 62:                 if line.find('rpc-auth-allow-insecure') != -1:


-- 
To view, visit http://gerrit.ovirt.org/36108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33bb4ef586bbad7fa3e2de29d63e4e6ff9d86bab
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbel...@gmail.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to