Allon Mureinik has posted comments on this change.

Change subject: core: Fix import from glance storage allocation check
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/37505/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java:

Line 249:         if (diskImage == null) {
Line 250:             return 
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_NOT_EXIST);
Line 251:         }
Line 252: 
Line 253: 
How is adding this newline relevant to the patch?
Line 254:         return validateSpaceRequirements(diskImage);
Line 255:     }
Line 256: 
Line 257:     protected boolean validateSpaceRequirements(DiskImage diskImage) {


-- 
To view, visit http://gerrit.ovirt.org/37505
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02d1cfb30c64a7d7b7b4c0386b134583faee190d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to