Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Sync job for gluster volume snapshots ......................................................................
Patch Set 16: (2 comments) http://gerrit.ovirt.org/#/c/35904/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java: Line 143: } Line 144: Line 145: // update snapshot details Line 146: Line 147: acquireLock(clusterId); > why a cluster level lock? As discussed will try to introduce new lock type gluster-snapshot and use it Line 148: try { Line 149: saveNewSnapshots(newlyAddedSnapshots); Line 150: updateSnapshots(updatedSnapshots); Line 151: deleteSnapshots(deletedSnapshots); Line 160: } Line 161: Line 162: private void addOrUpdateSnapshotsConfig(Guid clusterId, GlusterSnapshotConfigInfo configInfo) { Line 163: acquireLock(clusterId); Line 164: try { > why not try with? The acquireLock method does not return anything so we cannot use try with here Line 165: for (Map.Entry<String, String> entry : configInfo.getClusterConfigOptions().entrySet()) { Line 166: if (entry.getValue() != null) { Line 167: addOrUpdateClusterConfig(clusterId, entry.getKey(), entry.getValue()); Line 168: } -- To view, visit http://gerrit.ovirt.org/35904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b7bf79b72fc5680dab301b290e7aa860d5c714d Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
