Lior Vernia has posted comments on this change. Change subject: core,webadmin: remove validation for multicasts MAC addresses ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37499/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/AnyMacAddressValidation.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/AnyMacAddressValidation.java: Line 1: package org.ovirt.engine.ui.uicommonweb.validation; Line 2: Line 3: import org.ovirt.engine.ui.uicompat.ConstantsManager; Line 4: Line 5: public class AnyMacAddressValidation extends RegexValidation Why not just MacAddressValidation? Line 6: { Line 7: public AnyMacAddressValidation() Line 8: { Line 9: setExpression("^[a-fA-F0-9]{2}(:[a-fA-F0-9]{2}){5}$"); //$NON-NLS-1$ http://gerrit.ovirt.org/#/c/37499/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UnicastMacAddressValidation.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UnicastMacAddressValidation.java: Line 6: { Line 7: public UnicastMacAddressValidation() Line 8: { Line 9: setExpression("^[a-fA-F0-9][02468aAcCeE](:[a-fA-F0-9]{2}){5}$"); //$NON-NLS-1$ Line 10: setMessage(ConstantsManager.getInstance().getConstants().invalidMacAddressMsg()); I would expect here a more detailed message, saying something like "This field must contain a valid unicast MAC address". Line 11: } -- To view, visit http://gerrit.ovirt.org/37499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad61210f6f04c71dd9da15a6664f6b3075b3fc2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
