Tal Nisan has posted comments on this change. Change subject: webadmin: When creating LUN disk populate the description with the LUN id ......................................................................
Patch Set 4: (6 comments) http://gerrit.ovirt.org/#/c/37088/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java: Line 445: } Line 446: } Line 447: } Line 448: Line 449: private EventDefinition lunSelectionChangedEventDefinition = new EventDefinition("lunSelectionChanged", SanStorageModel.class); //$NON-NLS-1$ > instead of adding a new event, can't we just reuse the 'getPropertyChangedE But I need the listener to be in NewDiskModel, doesn't help me that SanStorageModel listens to it since it's redundant Line 450: private Event lunSelectionChangedEvent = new Event(lunSelectionChangedEventDefinition); Line 451: Line 452: public Event getLunSelectionChangedEvent() { Line 453: return lunSelectionChangedEvent; Line 462: Line 463: if (!selectedLunModel.getIsSelected() || !getItems().iterator().hasNext()) { Line 464: return; Line 465: } Line 466: > tws Done Line 467: // Clear LUNs selection Line 468: for (Model model : (List<Model>) getItems()) { Line 469: if (model instanceof LunModel) { Line 470: LunModel lunModel = (LunModel) model; http://gerrit.ovirt.org/#/c/37088/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java: Line 187: getVolumeType().setSelectedItem(storageType.isBlockDomain() ? VolumeType.Preallocated : VolumeType.Sparse); Line 188: volumeType_SelectedItemChanged(); Line 189: } Line 190: Line 191: private boolean descriptionDerivedFromLunId; > to keep convention, move global vars to top.. Done Line 192: Line 193: @Override Line 194: public void setSanStorageModel(SanStorageModel sanStorageModel) { Line 195: super.setSanStorageModel(sanStorageModel); Line 192: Line 193: @Override Line 194: public void setSanStorageModel(SanStorageModel sanStorageModel) { Line 195: super.setSanStorageModel(sanStorageModel); Line 196: sanStorageModel.getLunSelectionChangedEvent().getListeners().clear(); > to avoid clearing listeners which might be used by others, consider moving Done Line 197: sanStorageModel.getLunSelectionChangedEvent().addListener(new IEventListener() { Line 198: @Override Line 199: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 200: String description = getDescription().getEntity(); http://gerrit.ovirt.org/#/c/37088/4/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 104: --Handling Default Workgroup Line 105: select fn_db_add_config_value('DefaultWorkgroup','WORKGROUP','general'); Line 106: select fn_db_add_config_value('DisableFenceAtStartupInSec','300','general'); Line 107: select fn_db_add_config_value('DirectLUNDiskEnabled','false','3.0'); Line 108: select fn_db_add_config_value('PopulateDirectLUNDiskDescriptionWithLUNId','4','general'); > shouldn't it be added to ConfigValues/ConfigurationValues? It is added there... Line 109: --Handling NetBIOS Domain Name Line 110: select fn_db_add_config_value('DomainName','example.com','general'); Line 111: -- Host time drift Line 112: select fn_db_add_config_value('EnableHostTimeDrift','false','general'); http://gerrit.ovirt.org/#/c/37088/4/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 21: CpuOverCommitDurationMinutes.description="The duration in minutes of CPU consumption to activate selection algorithm" Line 22: CpuOverCommitDurationMinutes.type=Integer Line 23: DisableFenceAtStartupInSec.description="Disable Fence Operations At oVirt Startup In Seconds" Line 24: DisableFenceAtStartupInSec.type=Integer Line 25: PopulateDirectLUNDiskDescriptionWithLUNId.description="When creating direct LUN disk the number of characters from LUN id to populate the description with (-1 = the full id, 0 = none, <0 = number of characters)" > Why is it needed? Do we need to modify it manually? So it can be modified with the GSS config manager, we assume that some customers will like to get more/less characters of the id in the description Line 26: PopulateDirectLUNDiskDescriptionWithLUNId.type=Integer Line 27: ClusterEmulatedMachines.description="Supported machine types" Line 28: WANDisableEffects.description="Disabled WAN Effects value to send to the SPICE console" Line 29: WANDisableEffects.validValues=animation,wallpaper,font-smooth,all -- To view, visit http://gerrit.ovirt.org/37088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife497d61e4799dec5db6b8fc5007cac743969b2b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
