Simone Tiraboschi has uploaded a new change for review.

Change subject: packaging: setup: showing the GUID instead of the physical dev 
on iSCSI setup
......................................................................

packaging: setup: showing the GUID instead of the physical dev on iSCSI setup

iSCSI deploy presents to the user the list of available LUNs on the
selected target showing also the physical device.
That behaviour is not that much coherent on multipath deployments
where we found more than one physical devices for each LUN.

Change-Id: Ic8cd9c02e8c753db5df6816a38317b493c9b1e7f
Signed-off-by: Simone Tiraboschi <stira...@redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py
1 file changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup 
refs/changes/94/37494/1

diff --git a/src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py 
b/src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py
index b7de6af..ace9c1a 100644
--- a/src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py
+++ b/src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py
@@ -184,20 +184,21 @@
 
         lun_list = ''
         lun_size = {}
-        lun_device = {}
+        lun_guid = {}
         default = None
         for entry in available_luns:
+            lun = None
             for pathstatus in entry['pathstatus']:
-                lun_device[pathstatus['lun']] = pathstatus['physdev']
-                lun_size[
-                    pathstatus['lun']
-                ] = int(entry['capacity']) / pow(2, 20)
-        values = lun_device.keys()
+                lun = pathstatus['lun']
+            if lun:
+                lun_guid[lun] = entry['GUID']
+                lun_size[lun] = int(entry['capacity']) / pow(2, 20)
+        values = lun_guid.keys()
         values.sort()
         for lunid in values:
-            lun_list += '\t {lunid} - {physdev} - {size}MB\n'.format(
+            lun_list += '\t {lunid} - {GUID} - {size}MB\n'.format(
                 lunid=lunid,
-                physdev=lun_device[lunid],
+                GUID=lun_guid[lunid],
                 size=lun_size[lunid]
             )
         self.dialog.note(


-- 
To view, visit http://gerrit.ovirt.org/37494
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8cd9c02e8c753db5df6816a38317b493c9b1e7f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to