Shubhendu Tripathi has posted comments on this change. Change subject: gluster: VDS command to set volume snapshot config ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/36293/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1633: Line 1634: public StatusOnlyReturnForXmlRpc glusterVolumeSnapshotConfigSet(String volumeName, String configName, String configValue) { Line 1635: JsonRpcRequest request = Line 1636: new RequestBuilder("GlusterVolume.snapshotConfigSet").withParameter("volumeName", volumeName) Line 1637: .withParameter("option", configName) > I suggested this on vdsm patch as well. It would be good to have optionName sure. would change it. Line 1638: .withParameter("value", configValue) Line 1639: .build(); Line 1640: Line 1641: Map<String, Object> response = new FutureMap(this.client, request).withIgnoreResponseKey(); -- To view, visit http://gerrit.ovirt.org/36293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a4915b8f0f0b884d335fb238f866b5a7823fab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
