Piotr Kliczewski has posted comments on this change. Change subject: gluster: VDS Command - Gluster vol snapshot create ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/23212/20/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1586: return new StatusOnlyReturnForXmlRpc(response); Line 1587: } Line 1588: Line 1589: @Override Line 1590: public VMListReturnForXmlRpc getExternalVmList(String uri, String username, String password) { Are all 3 command changes are related to this patch? What do you think about updating them in separate patches? Line 1591: JsonRpcRequest request = Line 1592: new RequestBuilder("Host.getExternalVMs") Line 1593: .withParameter("uri", uri) Line 1594: .withParameter("username", username) -- To view, visit http://gerrit.ovirt.org/23212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib610f49c3b6c5aa108ce6fef0291cd9693429197 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
