Sahina Bose has posted comments on this change. Change subject: engine: vds command to list storage devices ......................................................................
Patch Set 11: (1 comment) How about handling of vdsm errors? No exceptions thrown by this verb? http://gerrit.ovirt.org/#/c/35313/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StorageDeviceListReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StorageDeviceListReturnForXmlRpc.java: Line 46: storageDevice.setName(map.get(NAME).toString()); Line 47: storageDevice.setSize((long) (map.containsKey(SIZE) ? Double.valueOf(map.get(SIZE).toString()) : 0)); Line 48: storageDevice.setDevPath(map.containsKey(DEV_PATH) ? map.get(DEV_PATH).toString() : null); Line 49: storageDevice.setCanCreateBrick(map.containsKey(CREATE_BRICK) ? Boolean.valueOf(map.get(CREATE_BRICK).toString()) : Boolean.FALSE); Line 50: storageDevice.setFsType(map.containsKey(FILE_SYSTEM_TYPE) && !map.get(FILE_SYSTEM_TYPE).toString().isEmpty() ? map.get(FILE_SYSTEM_TYPE) StringUtils.isBlank? Line 51: .toString() Line 52: : null); Line 53: storageDevice.setMountPoint(map.containsKey(MOUNT_POINT) && !map.get(MOUNT_POINT).toString().isEmpty() ? map.get(MOUNT_POINT) Line 54: .toString() -- To view, visit http://gerrit.ovirt.org/35313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id47eadcb57d3f544481b577da7507f4fc9a10c67 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
